All Mangas Reader

Discuss the extension, report bugs and request new features.
It is currently Tue Sep 19, 2017 11:38 am

All times are UTC




Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: AMR request
PostPosted: Sun Aug 25, 2013 8:28 pm 
Offline

Joined: Mon May 14, 2012 7:42 am
Posts: 6
Personally I would love to have the ability to just "run" AMR without it dialling home every 5 minutes.

As it stands, the manifest.json is VERY permissive about where it wants to run ( though I might be misinterpreting this part ) with the

"content_scripts": [ {
"css": [ "css/back.css" ],
"exclude_matches": [ "http://*.allmangasreader.com/*" ],
"js": [ "js/jquery.js", "js/jquery.scrollTo-1.4.3.1-min.js", "js/jquery.simplemodal-1.4.4.js", "js/back.js" ],
"matches": [ "http://*/*" ]
},

Which leads to fun things like ga.js + all your scripts being loaded on pages I host LOCALLY, as well as generating errors such as

"Denying load of chrome-extension://nhjloagockgobfpopemejpgjjechcpfd/js/jquery.min.map. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension. "

as well as "GET chrome-extension://invalid/ "

on my pages ( this lead to an hour or 2 of head scratching the 1st time or 2 )

I understand why you guys implemented the auto update mechanism, but I would actually prefer more customization on that ( EG I don't want your scripts to load on my... internet banking etc. ).

An off the top of my head idea of what I would like is:

* A manifests file that gets updated manually ( E.G. I click UPDATE NOW )
* No dialling home as an option ( yes I know you guys generate analytics, but I would prefer to opt out )
* The ability to configure the add-on to only run on white-listed mirrors ( this is my main point )

I think its probably possible to get the manifests file to only update on demand already, but since the add-on will still run all over, this is somewhat moot.

And PLEASE actually add the jquery.min.map to a release to remove the error ( AAH ).

NB - Sorry if I come across as a demanding asshole ;)

*edit* It is of course possible that I am totally wrong about the run-scope, I am somewhat assuming due to where I am seeing error messages in my console, and it is hardly my area of expertise.


Top
 Profile  
 
 Post subject: Re: AMR request
PostPosted: Sun Aug 25, 2013 11:18 pm 
Offline
AMR Hero

Joined: Fri Apr 27, 2012 5:10 pm
Posts: 586
Location: A Town far from you
Quote:
I understand why you guys implemented the auto update mechanism, but I would actually prefer more customization on that ( EG I don't want your scripts to load on my... internet banking etc. ).


It won't load on https sites. So your internet banking running over ssl (or so it should do) is out of our hands.

Quote:
As it stands, the manifest.json is VERY permissive about where it wants to run ( though I might be misinterpreting this part ) with the

"content_scripts": [ {
"css": [ "css/back.css" ],
"exclude_matches": [ "http://*.allmangasreader.com/*" ],
"js": [ "js/jquery.js", "js/jquery.scrollTo-1.4.3.1-min.js", "js/jquery.simplemodal-1.4.4.js", "js/back.js" ],
"matches": [ "http://*/*" ]
},


This was changed in our latest beta release. https://github.com/AllMangasReader-dev/ ... 3a517f2234

Quote:
No dialling home as an option ( yes I know you guys generate analytics, but I would prefer to opt out )

This was something I was concerned previously, but we lack of the legal knowledge to do a Privacy Statement. Either way, our analytics only loads for our supported sites, we don't get any other data. You can opt-out using the "Keep personal statistics data." but I don't know the extent of this. You can check all the statistics we collect in http://allmangasreader.com/stats.php

Quote:
A manifests file that gets updated manually ( E.G. I click UPDATE NOW )

Sorry, but I don't know what you mean with this.

Quote:
The ability to configure the add-on to only run on white-listed mirrors ( this is my main point )

I think this was answered in a previous point.

Quote:
And PLEASE actually add the jquery.min.map to a release to remove the error ( AAH ).

We don't depend on jquery.min.map. We don't need such library. This is only useful for Chrome installations that have activated the "map" option. We don't need such functionality for the users.

Quote:
I understand why you guys implemented the auto update mechanism, but I would actually prefer more customization on that ( EG I don't want your scripts to load on my... internet banking etc. ).

Quote:
I think its probably possible to get the manifests file to only update on demand already, but since the add-on will still run all over, this is somewhat moot.

Again, I don't understand the analogy. What have to do the manifest, with the updates of the extension, with the fact that it was running on all http sites? You can control how your extensions are updated in Chrome options. As an extension, we don't have anything to do but deliver updates to our users.

Quote:
"Denying load of chrome-extension://nhjloagockgobfpopemejpgjjechcpfd/js/jquery.min.map. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension. "

as well as "GET chrome-extension://invalid/ "


I say something was trying to access our resources, which are not allowed to anyone but our own extension. You can see the web_accessible_resources key in the manifest.json file to know what resources are accessible to websites, which is the bare minimum and extremally secure.

I would love if you clarify the point I didn't understand and do requests over the GitHub page. Please, an issue per request, since it's difficult to track several changes in just one issue number..

_________________
Know about me here


Top
 Profile  
 
 Post subject: Re: AMR request
PostPosted: Mon Aug 26, 2013 8:40 am 
Offline

Joined: Mon May 14, 2012 7:42 am
Posts: 6
Quote:
It won't load on https sites. So your internet banking running over ssl (or so it should do) is out of our hands.


I did pick up on this - however some banks still use http. (I realize that if, in fact you are using a bank that is using http then AMR is probably the least of your worries, but still...)

Quote:
This was changed in our latest beta release. https://github.com/AllMangasReader-dev/ ... 3a517f2234


YAY. this was one of my main frustrations.

Quote:
A manifests file that gets updated manually ( E.G. I click UPDATE NOW )


Effects of doing this at some time early in the morning without sleep :( I meant the ability to manually update the db where the implementations are kept. I assume the beta also addresses that.

Quote:
"Denying load of chrome-extension://nhjloagockgobfpopemejpgjjechcpfd/js/jquery.min.map. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension. "


Your jquery.js on line 2 has some kind of conditional in it that calls jquery.min.map

//@ sourceMappingURL=jquery.min.map

I'm trying to avoid github for some reason :(


Top
 Profile  
 
 Post subject: Re: AMR request
PostPosted: Mon Aug 26, 2013 11:21 am 
Offline
AMR Hero

Joined: Fri Apr 27, 2012 5:10 pm
Posts: 586
Location: A Town far from you
bob@mailinator.com wrote:
Effects of doing this at some time early in the morning without sleep :( I meant the ability to manually update the db where the implementations are kept. I assume the beta also addresses that.
There was a functionality like that, but was dropped since we determined that each 24 hours is enough. You can force an update hitting the popup clock icon (as shown here http://wiki.allmangasreader.com/trouble ... e_are_they)

bob@mailinator.com wrote:
braiam wrote:
"Denying load of chrome-extension://nhjloagockgobfpopemejpgjjechcpfd/js/jquery.min.map. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension. "


Your jquery.js on line 2 has some kind of conditional in it that calls jquery.min.map

//@ sourceMappingURL=jquery.min.map

I'm trying to avoid github for some reason :(


I'm not able to reproduce this in any of my builds, what is the exact steps that you do to trigger this effect. Also, check your "Developers" settings, if the General > Sources section has "Enable source maps" activated.

Image

_________________
Know about me here


Top
 Profile  
 
 Post subject: Re: AMR request
PostPosted: Tue Aug 27, 2013 12:49 pm 
Offline

Joined: Mon May 14, 2012 7:42 am
Posts: 6
%appdata%\..\Local\Google\Chrome\User Data\Default\Extensions\nhjloagockgobfpopemejpgjjechcpfd\1.5.4_0\js\jquery.js line #2 is a conditional comment to jquery.min.map - removing it fixes the error messages. :)

I do have source maps enabled.

Quote:
There was a functionality like that, but was dropped since we determined that each 24 hours is enough.


Personally, I would like to have this functionality re-enabled, with the option to disable automatic polling.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group